Skip to content

Fix deprecated GitHub authentication in retrosheet.py #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yasumorishima wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix deprecated GitHub authentication in retrosheet.py #501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions pybaseball/retrosheet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
from pybaseball.utils import get_text_file
from datetime import datetime
from io import StringIO
from github import Github
from github import Auth, Github
import os
from getpass import getuser, getpass
from github.GithubException import RateLimitExceededException
Expand Down Expand Up @@ -131,7 +131,7 @@ def events(season, type='regular', export_dir='.'):
"the valid types are: 'regular', 'post', and 'asg'.")

try:
g = Github(GH_TOKEN)
g = Github(auth=Auth.Token(GH_TOKEN)) if GH_TOKEN else Github()
repo = g.get_repo('chadwickbureau/retrosheet')
season_folder = [f.path[f.path.rfind('/')+1:] for f in repo.get_contents(f'seasons/{season}')]
season_events = [t for t in season_folder if t.endswith(file_extension)]
Expand All @@ -156,7 +156,7 @@ def rosters(season):
GH_TOKEN=os.getenv('GH_TOKEN', '')

try:
g = Github(GH_TOKEN)
g = Github(auth=Auth.Token(GH_TOKEN)) if GH_TOKEN else Github()
repo = g.get_repo('chadwickbureau/retrosheet')
season_folder = [f.path[f.path.rfind('/')+1:] for f in repo.get_contents(f'seasons/{season}')]
rosters = [t for t in season_folder if t.endswith('.ROS')]
Expand All @@ -179,7 +179,7 @@ def _roster(team, season, checked = False):
GH_TOKEN=os.getenv('GH_TOKEN', '')

if not checked:
g = Github(GH_TOKEN)
g = Github(auth=Auth.Token(GH_TOKEN)) if GH_TOKEN else Github()
try:
repo = g.get_repo('chadwickbureau/retrosheet')
season_folder = [f.path[f.path.rfind('/')+1:] for f in repo.get_contents(f'seasons/{season}')]
Expand Down Expand Up @@ -213,7 +213,7 @@ def schedules(season):
"""
GH_TOKEN=os.getenv('GH_TOKEN', '')
# validate input
g = Github(GH_TOKEN)
g = Github(auth=Auth.Token(GH_TOKEN)) if GH_TOKEN else Github()
repo = g.get_repo('chadwickbureau/retrosheet')
season_folder = [f.path[f.path.rfind('/')+1:] for f in repo.get_contents(f'seasons/{season}')]
file_name = f'{season}schedule.csv'
Expand All @@ -231,7 +231,7 @@ def season_game_logs(season):
"""
GH_TOKEN=os.getenv('GH_TOKEN', '')
# validate input
g = Github(GH_TOKEN)
g = Github(auth=Auth.Token(GH_TOKEN)) if GH_TOKEN else Github()
repo = g.get_repo('chadwickbureau/retrosheet')
season_folder = [f.path[f.path.rfind('/')+1:] for f in repo.get_contents(f'seasons/{season}')]
gamelog_file_name = f'GL{season}.TXT'
Expand Down