Fix ASCII fallback for box-drawing chars when alt charset unsupported#1638
Merged
Conversation
…s unsupported When a terminal does not support alternate charset mode (enter_alt_charset_mode / exit_alt_charset_mode capabilities), box-drawing Unicode characters like '─' were passed through as-is. Terminals that cannot render these characters would display garbled output (e.g., 'qqqqqq' instead of '------' for horizontal lines). Add an else branch that converts box-drawing characters to ASCII equivalents: ─ → - │ → | corners/intersections → + Fixes #1259
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
smacs/rmacs), box-drawing Unicode characters were passed through as-isTERM=screen-256color) displayed garbled output likeqqqqqqinstead of horizontal lines─→-,│→|, corners/intersections →+Fixes #1259
Test plan
./mvx mvn -pl terminal -am testpassesTERM=screen-256colorthat TailTipWidgets separator renders as------instead ofqqqqqq