Applying crypto DOGE fix from #220#276
Open
hoggatt wants to merge 1 commit into
Open
Conversation
|
Buying by Quantity does work as long as the quantity is submitted as an integer. Even on the Robinhood app I can't buy fractional DOGE. I think it's limited on the server side, and until they open that up on their end, this will not work. |
|
Ofc. I'm not saying your script won't work. Obviously it does (I've tested it myself from the original post.) But it's a bit confusing, as you said because of having a whole 'nother argument. Is it reasonable to code in a DOGE check, or look for the return statement from Robinhood saying "Order quantity not valid." and resubmitting until it gets a proper Order payload? I'm not as fluent in these conventions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Honestly, I'm not 100% sure this is the right fix. It should work, but it would be nice not to have another argument to enter. I think this will be confusing to some people.
I just wanted to get the ball rolling here in hopes we can figure out a good solution. Would be nice to be able to buy and sell DOGE without having to worry about these issues.