Skip to content

add start_date=None to get_all_open_option_orders()#525

Open
mw66 wants to merge 2 commits into
jmfernandes:masterfrom
mw66:fix_2
Open

add start_date=None to get_all_open_option_orders()#525
mw66 wants to merge 2 commits into
jmfernandes:masterfrom
mw66:fix_2

Conversation

@mw66

@mw66 mw66 commented Dec 26, 2024

Copy link
Copy Markdown

fix : #507

continuation of: #517

Just add start_date=None to get_all_open_option_orders()

@mw66

mw66 commented Dec 26, 2024

Copy link
Copy Markdown
Author

@jmfernandes @noLeash

fix : #507

continuation of: #517

@mw66

mw66 commented Jan 17, 2025

Copy link
Copy Markdown
Author

@jmfernandes can you take a look of this simple PR?

@mw66

mw66 commented Jan 21, 2025

Copy link
Copy Markdown
Author

@jmfernandes can you take a look of this simple PR?

It contains important fix.

Thanks

@mw66

mw66 commented Mar 31, 2025

Copy link
Copy Markdown
Author

@jmfernandes can you merge this simple and important PR?

@mw66

mw66 commented Mar 31, 2025

Copy link
Copy Markdown
Author

For people who need this fix, please install from here:

pip3 install -U git+https://github.com/mw66/robin_stocks.git@fix_2

@mw66 mw66 mentioned this pull request Apr 15, 2025
@mw66

mw66 commented Apr 13, 2026

Copy link
Copy Markdown
Author

@jmfernandes can you merge this simple and important PR?

@mw66

mw66 commented Apr 18, 2026

Copy link
Copy Markdown
Author

@noLeash

Can you take a look of this simple PR, which just fix a few small things you left out from you PR 517 (thank you for the fix).

This PR is more than a year now, not sure if Josh has checked it. Maybe because I never contributed to this repo before, so he didn't take a look.

If you think it's ok, can you try to create a new PR, and submit for merge? Maybe Josh will take the PR from you.

Thanks.

DhruvaBansal00 added a commit to DhruvaBansal00/robin_stocks that referenced this pull request May 23, 2026
Upstream PR jmfernandes#525 (jmfernandes/robin_stocks). option_orders_url already
accepts start_date, but the public helper wasn't threading it through.
Also forwards the new param via the MCP rh_get_all_open_option_orders tool.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
DhruvaBansal00 added a commit to DhruvaBansal00/robin_stocks that referenced this pull request May 23, 2026
@DhruvaBansal00

Copy link
Copy Markdown

Thanks for this contribution! jmfernandes/robin_stocks appears to be unmaintained, so I've started a community-maintained fork at https://github.com/DhruvaBansal00/robin_stocks_v2 and merged this PR there: DhruvaBansal00/robin_stocks_v2@b649605

It's included with test coverage in the new repo, alongside 11 other open PRs from here. If you'd like a maintained build with this change, that's where to find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

anyone experienced rh.get_all_open_option_orders(account_number=acct) is very slow? e.g. ~2 minutes

3 participants