Skip to content

Sim w/o global session #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joeblackwaslike wants to merge 11 commits into
base: simple
Choose a base branch
from

Update project configuration and dependencies; remove .flake8 and .se…

38cf5a1
Select commit
Loading
Failed to load commit list.
Open

Sim w/o global session #6

Update project configuration and dependencies; remove .flake8 and .se…
38cf5a1
Select commit
Loading
Failed to load commit list.
Cursor / Cursor Bugbot completed Sep 28, 2025 in 3m 4s

Bugbot Review

Bugbot Analysis Progress (3m 5s elapsed)

✅ Gathered PR context (2s)
✅ Analyzed code changes (1s)
✅ Completed bug detection — 5 potential bugs found (2m 54s)
✅ Validation and filtering completed (0s)
✅ Posted analysis results — 5 bugs reported (8s)
✅ Analysis completed successfully (0s)

Final Result: Bugbot completed review and found 5 potential issues

Request ID: serverGenReqId_c471a79a-8882-4b3e-9c10-09af52093a43

Details

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bug: Reactivation Method Incorrectly Sets Status

The reactivate method currently sets an entity's is_active status to False. This seems like a bug, as reactivating an entity should likely set is_active to True.

src/quart_sqlalchemy/sim/repo.py#L287-L289

quart-sqlalchemy/src/quart_sqlalchemy/sim/repo.py

Lines 287 to 289 in 38cf5a1

def reactivate(self, session: sa.orm.Session, id_: EntityIdT) -> EntityT:
return self.update(session, id_, dict(is_active=False))

examples/repository/sqla.py#L216-L220

quart-sqlalchemy/examples/repository/sqla.py

Lines 216 to 220 in 38cf5a1

if self.has_soft_delete:
raise RuntimeError("Can't delete entity that uses soft-delete semantics.")
entity = self.get(id_)
if not entity:

Fix in Cursor Fix in Web

View more details on Cursor