Fixes Set handling in filterWhere #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s implements Iterable<T> to simplify string joining for Set operators
jamessimone
commented
Sep 12, 2023
Owner
|
@jamessimone this looks great! I still don't have a pipeline setup for this repo, but I can create & publish a new package version tomorrow. Thanks for working on this! |
Collaborator
Author
|
Awesome, happy to help! |
…spaces to explicitly include the namespaces
Owner
|
@jamessimone FYI I pushed a few extra changes to this branch to bump the API version everywhere to v58.0 and just a little scope-creep on some code cleanup. |
Collaborator
Author
|
Awesome - looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Fixes #43 by upgrading SOQl.cls to API version 58, where Set always implements Iterable to simplify string joining for Set operators