Support reconnecting to an existing session#100
Draft
travisbrown wants to merge 2 commits intojonhoo:mainfrom
Draft
Support reconnecting to an existing session#100travisbrown wants to merge 2 commits intojonhoo:mainfrom
travisbrown wants to merge 2 commits intojonhoo:mainfrom
Conversation
Owner
|
Nice! I wonder if we could easily share some of this code between |
16 tasks
|
Is this still being worked on? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a sketch of a minimal fix for #57 that just copies what
with_capabilitiesis doing but without issuing theNewSessioncommand.I've confirmed that this implementation does what I need right now (allows me to have a CLI that doesn't have to log in to a site on every invocation, for example), but it should probably also do things like try to read the value of
is_legacyoff the WebDriverstatusfor the session. It also needs tests, etc.