code_refactor: making is_number logic more readable#41
Open
waiz3ple wants to merge 1 commit intojonschlinkert:masterfrom
Open
code_refactor: making is_number logic more readable#41waiz3ple wants to merge 1 commit intojonschlinkert:masterfrom
waiz3ple wants to merge 1 commit intojonschlinkert:masterfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Viswesh934
approved these changes
Nov 13, 2025
7aimez
approved these changes
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Jonschlinkert,
I hope you're having a great day!
I’ve updated the is_number logic to enhance its readability. While reviewing the code, I noticed that Number.isFinite was carefully used due to browser compatibility concerns at the time it was written. However, Number.isFinite now has significantly wider support and is more reliable compared to the older isFinite function, which is less precise.
Let me know if there’s anything else you'd like me to address!