[6.2] Scheduler: Don't use Toolbar::getInstance()#47442
Open
Hackwar wants to merge 5 commits intojoomla:6.2-devfrom
Open
[6.2] Scheduler: Don't use Toolbar::getInstance()#47442Hackwar wants to merge 5 commits intojoomla:6.2-devfrom
Hackwar wants to merge 5 commits intojoomla:6.2-devfrom
Conversation
HLeithner
changed the title
Contributor
|
Looks like there are 6.1 files here that should not be part of the commit |
Contributor
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Member
Author
|
Yes, that will be resolved when there is an upmerge. |
Contributor
|
Please check as it looks like they're already up merged and it's why there is a conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
We've got all views refactored to use the getToolbar method, except for this case. So lets refactor this.
Testing Instructions
Codereview
Link to documentations
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed