feat: allow using notebook for storing templates#63
Merged
nishantwrp merged 6 commits intojoplin:masterfrom Jun 4, 2022
BeatLink:master
Merged
feat: allow using notebook for storing templates#63nishantwrp merged 6 commits intojoplin:masterfrom BeatLink:master
nishantwrp merged 6 commits intojoplin:masterfrom
BeatLink:master
Conversation
nishantwrp
requested changes
Mar 30, 2022
nishantwrp
requested changes
Apr 4, 2022
Collaborator
nishantwrp
left a comment
nishantwrp
left a comment
There was a problem hiding this comment.
Hi @BeatLink, along with the code can you also update the documentation (README.md)?
Contributor
Author
|
Done |
Contributor
Author
|
Any plans on when this will be implemented? I've been using it without issues for the past month. |
Collaborator
|
Hi @BeatLink, will review this within this week. |
Contributor
Author
|
Hi there. Any updates? |
nishantwrp
changed the title
nishantwrp
reviewed
Jun 2, 2022
Collaborator
nishantwrp
left a comment
nishantwrp
left a comment
There was a problem hiding this comment.
Hi @BeatLink, sorry for the delay. I've made some changes in this pull request and made another PR to your branch. Once you merge that we'll be good to go.
Link to the pull request - https://github.com/BeatLink/plugin-templates/pull/1
refactor: update documentation and variable names
Contributor
Author
|
Looks good! Changes merged as requested. |
nishantwrp
approved these changes
Jun 4, 2022
Collaborator
nishantwrp
left a comment
nishantwrp
left a comment
There was a problem hiding this comment.
lgtm, thanks @BeatLink!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements Feature Request #62