As Math.random always returns a number lower than 1, the return value…#21
Open
per-oestergaard wants to merge 1 commit intojuliangruber:masterfrom
Open
As Math.random always returns a number lower than 1, the return value…#21per-oestergaard wants to merge 1 commit intojuliangruber:masterfrom
per-oestergaard wants to merge 1 commit intojuliangruber:masterfrom
Conversation
… should be multiplied with the max value wanted plus 1.
|
Math.random does not provide sufficient entropy to be considered in cryptographic systems. It should not be used as it will result in weak cryptography. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… should be multiplied with the max value wanted plus 1.
If not the full range of values are not returned making the random values 1/256th less random.
Fell free to correct me, if I am wrong.