Fix CI: Pin nushell version to 0.114 - #4898
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the NuShell package version used in the Linux GitHub Actions workflow to avoid a NuShell 0.115.x regression that breaks fzf interaction during CI runs (per linked upstream issue).
Changes:
- Add an inline rationale comment referencing the upstream NuShell regression.
- Change the CI package install step to install
nushell=0.114.1-0instead of the latestnushell.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+41
to
+42
| # Pinned: 0.115.0 runs external completers on a background thread, so | ||
| # fzf never receives keystrokes. https://github.com/nushell/nushell/issues/18771 |
hmr
pushed a commit
to hmr/fzf-hmr
that referenced
this pull request
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4896
nushell/nushell#18771
Contribution Policy
We do not accept pull requests generated primarily by AI without genuine understanding or real-world usage context.
All contributions are expected to demonstrate:
If these expectations are not met, we would prefer to implement the changes ourselves rather than spend time reviewing low-effort submissions.
Acknowledgement