CMake usage of QV_DISABLE_ONLINE_VERSION_CHECK has the inverse logic

[Aditya-Tolikar]

• Having QV_DISABLE_ONLINE_VERSION_CHECK:BOOL=OFF
  Causes version check code to not be compiled while updatechecker.cpp is still included in the project.

• Having QV_DISABLE_ONLINE_VERSION_CHECK:BOOL=ON
  Causes updatechecker.cpp and updatechecker.h to not be included in the project, while the corresponding code in other files is compiled, giving an error.

---

Solution:

From 3f0464819e1c9ded32b547ec85e2643859242a4b Mon Sep 17 00:00:00 2001
From: Aditya Tolikar <adityatolikar@gmail.com>
Date: Mon, 9 Feb 2026 19:24:01 +0530
Subject: [PATCH] Fix wrong logic for QV_DISABLE_ONLINE_VERSION_CHECK

---
 CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index af719f9..2dea0d5 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -147,7 +147,7 @@ if(UNIX AND NOT APPLE)
 endif()
 
 # Add compile definitions based on options
-if(NOT QV_DISABLE_ONLINE_VERSION_CHECK)
+if(QV_DISABLE_ONLINE_VERSION_CHECK)
     target_compile_definitions(${PROJECT_NAME} PRIVATE QV_DISABLE_ONLINE_VERSION_CHECK)
 endif()
 
-- 
2.52.0

[jurplel]

🤦