Add getRightmostFailure function for debugging match failures#48
Merged
justinmchase merged 4 commits intomainfrom Oct 22, 2025
Merged
Add getRightmostFailure function for debugging match failures#48justinmchase merged 4 commits intomainfrom
justinmchase merged 4 commits intomainfrom
Conversation
Co-authored-by: justinmchase <10974+justinmchase@users.noreply.github.com>
Co-authored-by: justinmchase <10974+justinmchase@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add function to find right most failure in matches
Add getRightmostFailure function for debugging match failures
Oct 22, 2025
justinmchase
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added a new
getRightmostFailure()function that traverses aMatchFailtree to find the failure with the greatest start span position. This helps debug parser failures by identifying where the parse actually got the furthest before failing.Background
When a pattern fails to match, the resulting
MatchFailcan have a complex structure of nested failures with child matches. During debugging, the "rightmost" failure (the one that progressed furthest into the input) typically indicates where the actual problem is located.Implementation
The new function:
MatchFailtreePath.compareTo()methodMatchFailtypes (ignoresMatchOk,MatchLR,MatchError)Usage Example
Testing
Added comprehensive unit tests in
src/match.test.tscovering:Closes #[issue_number]
Original prompt
Fixes #47
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.