Skip to content

Conversation

@hieuk09
Copy link
Contributor

@hieuk09 hieuk09 commented Apr 4, 2025

Description

I see that the test fails when running versus Ruby head. It seems like latest ruby removes logger from the bundled gems

Screenshot 2025-04-05 at 6 16 40 AM

Checklist

Before the PR can be merged be sure the following are checked:

  • There are tests for the fix or feature added/changed
  • A description of the changes and a reference to the PR has been added to CHANGELOG.md. More details in the CONTRIBUTING.md

@anakinj
Copy link
Member

anakinj commented Apr 7, 2025

Thanks for taking a look at this @hieuk09 . Could you maybe extract the fix in your other PR into this one. To get the CI green before tackling the features.

@hieuk09
Copy link
Contributor Author

hieuk09 commented Apr 7, 2025

Sure, I'll do it soon.

@anakinj anakinj merged commit bbbd69d into jwt:main Apr 7, 2025
22 checks passed
@hieuk09 hieuk09 deleted the chore/add-logger-dependencies branch April 7, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants