refactor(make): rearrange targets#2569
Merged
zerospiel merged 2 commits intok0rdent:mainfrom Mar 30, 2026
Merged
Conversation
zerospiel
requested review from
BROngineer,
Kshatrix,
a13x5,
eromanova,
kylewuolle and
wahabmk
as code owners
Move several bash-like targets into dedicated bash scripts. Comment all of the public targets, rearrange according to classes. Several bug-, security- and style-fixes: - ran shftm - ran shellcheck - removed empty sudo rm rf - improved files/directories checks
eromanova
reviewed
Mar 30, 2026
Collaborator
eromanova
left a comment
eromanova
left a comment
There was a problem hiding this comment.
LGTM overall. Could you please run the e2e tests (with the default provider) to ensure everything still works as expected? Thanks.
zerospiel
added
the
test e2e
zerospiel
removed
the
test e2e
Collaborator
Author
|
@eromanova tests ok, thanks for the review |
eromanova
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move several bash-like targets into dedicated bash scripts.
Comment all of the public targets, rearrange according to classes.
Several bug-, security- and style-fixes:
Which issue(s) this PR fixes (optional,
Fixes #123):Closes #589