Skip to content

fix: Custom registryCredentialsConfig in helmCharts of kof-istio#473

Merged
denis-ryzhkov merged 1 commit into
k0rdent:mainfrom
denis-ryzhkov:custom-istio-helmrepo-certs
Aug 8, 2025
Merged

fix: Custom registryCredentialsConfig in helmCharts of kof-istio#473
denis-ryzhkov merged 1 commit into
k0rdent:mainfrom
denis-ryzhkov:custom-istio-helmrepo-certs

Conversation

@denis-ryzhkov
Copy link
Copy Markdown
Collaborator

  • kof-istio does not use ServiceTemplates (where we added cert/secretRefs already) because it needs dependsOn feature not supported by MCS yet.
  • Despite CASecretRef mentioned in https://projectsveltos.github.io/sveltos/addons/helm_charts/#example-private-registry the expected JSON field name is ca - https://github.com/projectsveltos/addon-controller/blob/v0.57.2/api/v1beta1/spec.go#L167
  • Testing with values:
    kcm:
      kof:
        repo:
          spec:
            secretRef:
              name: foo
            certSecretRef:
              name: bar
    
  • Result:
    kubectl get ClusterProfile -o yaml | grep -C5 registryCredentialsConfig
    
        helmCharts:
        - chartName: kof/kof-operators
          chartVersion: 1.2.0
          helmChartAction: Install
          registryCredentialsConfig:
            ca:
              name: bar
            credentials:
              name: foo
          releaseName: kof-operators
    --
        - chartName: kof/kof-collectors
          chartVersion: 1.2.0
          helmChartAction: Install
          registryCredentialsConfig:
            ca:
              name: bar
            credentials:
              name: foo
          releaseName: kof-collectors
    --
        - chartName: cert-manager
          chartVersion: v1.16.4
          helmChartAction: Install
          registryCredentialsConfig:
            ca:
              name: bar
            credentials:
              name: foo
          releaseName: cert-manager
    
    and 5 more, OK.

@denis-ryzhkov denis-ryzhkov merged commit 5f6f3dd into k0rdent:main Aug 8, 2025
6 checks passed
@github-project-automation github-project-automation Bot moved this to Done in k0rdent Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant