fix: correctly parse and render total metric values and labels (not just last label) in kof UI#486
Merged
Conversation
7219482 to
ed596bb
Compare
gmlexx
requested changes
Aug 19, 2025
ed596bb to
2d45933
Compare
…ust last label) in kof UI
2d45933 to
96a3d36
Compare
gmlexx
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where metrics with multiple labels were not parsed and rendered correctly. The UI previously receive and used a single (last) label value instead of aggregating and exposing all labels and values. The Prometheus parser, backend response format, and UI rendering were updated so metrics now include distinct label entries and a value.
Examples Prometheus metric input:
Before (incorrect) metrics were parsed into a single numeric value:
After (correct) backend now returns separated labels and values:
{ "vl_data_size_bytes": [ { "labels": { "type": "indexdb" }, "value": 199695 }, { "labels": { "type": "storage" }, "value": 125139890 } ] }