fix: prevent duplicate metric collection#488
Merged
Merged
Conversation
Collaborator
|
@aglarendil please have a look |
AndrejsPon00
force-pushed
the
fix-metric-dups
branch
from
5baf975 to
6e46e21
Compare
AndrejsPon00
force-pushed
the
fix-metric-dups
branch
2 times, most recently
from
2aefc26 to
5dd93a4
Compare
AndrejsPon00
force-pushed
the
fix-metric-dups
branch
from
5dd93a4 to
b5be8cf
Compare
aglarendil
approved these changes
Aug 26, 2025
denis-ryzhkov
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #411
Removed the
node-exporterjob from the daemon collector scrape configAdded
nodeandnodenamelabels to theprometheus-node-exporterServiceMonitor so Grafana dashboards continue to render correctly.Dashboards related to Node Exporter metrics rendered correctly (tested on a regional cluster):
Dropped scraping of
kube-proxyandkube-dnspods in the collector daemon scrape config (kubernetes-podsjob) to prevent duplicate metrics on regional and child clusters.Dashboards related to
Kube-dnsandKube-proxymetrics rendered correctly (tested on a regional cluster):