chore: KOF 1.5.0-rc1#602
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This is a release candidate (KOF 1.5.0-rc1) that updates dependencies and enforces stricter code quality standards through golangci-lint v2.5.0 migration and associated lint fixes.
- Upgraded golangci-lint from v1.64.7 to v2.5.0 and updated its configuration to use the new v2 syntax
- Updated Go toolchain and all major dependencies (Kubernetes, Prometheus, Grafana Operator, etc.)
- Applied automated lint fixes including replacing deprecated APIs and simplifying logic
Reviewed Changes
Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| kof-operator/go.mod | Updated Go version to 1.25.1 and bumped all dependencies to latest versions |
| kof-operator/Makefile | Updated golangci-lint version and import path for v2 |
| kof-operator/.golangci.yml | Migrated to golangci-lint v2 configuration syntax with new formatter/exclusion structure |
| kof-operator/test/utils/utils.go | Replaced deprecated nolint directive and used strings.ReplaceAll |
| kof-operator/internal/models/target/targets.go | Simplified method calls by removing redundant receiver references |
| kof-operator/internal/metrics/health.go | Improved error message clarity with "the" article |
| kof-operator/internal/controller/promxyservergroup_controller_test.go | Simplified ObjectMeta.Labels access |
| kof-operator/internal/controller/configmap_cluster_regional.go | Fixed Duration.Seconds() calls (removed redundant .Duration) |
| kof-operator/internal/controller/alerts_configmap_controller.go | Simplified boolean logic using De Morgan's law |
| demo/cluster/*.yaml | Updated template versions and added cleanupOnDeletion: true |
| .github/actions/setup-yq/action.yaml | Switched from wget to curl for consistency |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bin/golangci-lint-v2.5.0 migratecache-dependency-path: kof-operator/go.sumin cachedactions/setup-goand bumped
CONTROLLER_TOOLS_VERSIONfrom v0.16.1 to v0.19.0to fix CI-only error
invalid array length -delta * delta (constant -256 of type int64).github/actions/setup-yqfromwgettocurl.cleanupOnDeletion: truetodemo/clusters.