fix: cleanup child ConfigMap propagation MCS after ClusterDeployment deletion#617
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a resource leak by ensuring that MultiClusterService (MCS) resources used for child ConfigMap propagation are properly cleaned up when a ClusterDeployment is deleted. The fix adds a check in the reconciliation loop to detect when a ClusterDeployment has been deleted (NotFound error) and triggers the cleanup of the associated MCS resource.
- Adds deletion detection in the Reconcile method to handle ClusterDeployment removal
- Renames parameter in CleanupChildConfigMapMcsPropagation for clarity
- Ensures MCS cleanup is invoked before returning from reconciliation
denis-ryzhkov
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #582