fix: prevent chart reinstallation by adding service dependsOn to region/child MCS#623
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds explicit service dependencies to Multi-Cluster Service (MCS) definitions in regional and child cluster Helm charts to prevent premature chart installations and ensure proper deployment ordering.
Key Changes:
- Added
dependsOndeclarations to enforce deployment order of services in MCS definitions - Ensures cert-manager is installed before dependent services
- Creates proper dependency chain: cert-manager → ingress-nginx → kof-operators → kof-storage → kof-collectors
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/kof-regional/templates/regional-multi-cluster-service.yaml | Added dependsOn fields to ingress-nginx (depends on cert-manager), kof-operators (conditionally depends on ingress-nginx), kof-storage (depends on kof-operators), and kof-collectors (depends on kof-storage) |
| charts/kof-child/templates/child-multi-cluster-service.yaml | Added dependsOn fields to kof-operators (conditionally depends on cert-manager) and kof-collectors (depends on kof-operators) |
AndrejsPon00
force-pushed
the
fix-mcs-service-deps
branch
from
d367abb to
0c37ffc
Compare
denis-ryzhkov
previously approved these changes
Nov 10, 2025
AndrejsPon00
force-pushed
the
fix-mcs-service-deps
branch
from
bbd0166 to
27030a8
Compare
denis-ryzhkov
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.