fix: add metrics-server to resolve metric errors in KOF UI in local environment#655
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the metrics-server component in local development environments to resolve metric-related errors in the KOF UI. The metrics-server is added as a chart dependency and configured for both the mothership (management cluster) and adopted clusters with insecure TLS settings appropriate for local development.
Key changes:
- Add metrics-server as a Helm chart dependency to
kof-mothershipandkof-collectors - Configure metrics-server with
--kubelet-insecure-tlsflag for local dev environments - Enable metrics-server in demo cluster configurations and local development Makefile
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/kof-mothership/Chart.yaml | Adds metrics-server 3.12.1 as a conditional chart dependency |
| charts/kof-mothership/values.yaml | Defines metrics-server configuration with insecure TLS arg and disabled by default |
| charts/kof-collectors/Chart.yaml | Adds metrics-server 3.12.1 as a conditional chart dependency |
| charts/kof-collectors/values.yaml | Defines metrics-server configuration with insecure TLS arg and disabled by default |
| demo/cluster/adopted-cluster-regional.yaml | Enables metrics-server via cluster annotations |
| demo/cluster/adopted-cluster-kcm-region.yaml | Enables metrics-server via cluster annotations in config |
| demo/cluster/adopted-cluster-istio-regional.yaml | Enables metrics-server via cluster annotations in config |
| demo/cluster/adopted-cluster-istio-child.yaml | Enables metrics-server via cluster annotations in config |
| demo/cluster/adopted-cluster-child.yaml | Enables metrics-server inline in values |
| Makefile | Enables metrics-server in dev-ms-deploy target for local development |
AndrejsPon00
force-pushed
the
add-metrics-server
branch
3 times, most recently
from
5cd78ba to
a5049d4
Compare
denis-ryzhkov
previously approved these changes
Dec 4, 2025
gmlexx
previously approved these changes
Dec 4, 2025
AndrejsPon00
force-pushed
the
add-metrics-server
branch
from
a5049d4 to
270aaa3
Compare
AndrejsPon00
dismissed stale reviews from denis-ryzhkov and gmlexx
via
743bf6c
AndrejsPon00
force-pushed
the
add-metrics-server
branch
from
743bf6c to
6a5a7e6
Compare
AndrejsPon00
force-pushed
the
add-metrics-server
branch
2 times, most recently
from
18d0cf6 to
51ad304
Compare
AndrejsPon00
force-pushed
the
add-metrics-server
branch
from
4aa1b1c to
ac3efd8
Compare
gmlexx
reviewed
Dec 18, 2025
denis-ryzhkov
requested changes
Dec 18, 2025
AndrejsPon00
force-pushed
the
add-metrics-server
branch
from
540f8e9 to
20b29fb
Compare
AndrejsPon00
force-pushed
the
add-metrics-server
branch
from
20b29fb to
d763e70
Compare
denis-ryzhkov
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #618
This PR adds the metrics-server for adopted and management (mothership) clusters.