fix: prevent grafana operator reconciliation issue due to missing creds#657
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Grafana operator reconciliation issue during helm uninstall by preventing premature deletion of the credentials secret. The operator was attempting to reconcile the Grafana CR even after deletion started, causing failures when the credentials secret was already removed.
Key Changes:
- Added
helm.sh/resource-policy: keepannotation to the Grafana credentials secret to prevent its deletion during helm uninstall, avoiding reconciliation conflicts.
gmlexx
force-pushed
the
fix-grafana-cr-deletion-2
branch
from
cff9913 to
753d12b
Compare
denis-ryzhkov
approved these changes
Dec 4, 2025
denis-ryzhkov
pushed a commit
that referenced
this pull request
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uninstallation via helm uninstall --wait --cascade foreground -n kof kof-mothership takes too much time due to grafana-operator reconciliation issue where despite the deletion of grafana CR the operator is still trying to create it but failed as the credentials secret already deleted.