chore: prevent kcm-controller crashes after kcm upgrade in CI#693
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses crashes in the kcm-controller during KCM upgrades in CI by adding a new Makefile target that sets a memory limit before performing the upgrade. The change ensures consistent resource constraints across CI workflows to prevent controller instability.
Key changes:
- Adds a new
kcm-dev-upgradetarget in the Makefile that configures memory limits (128Mi) before upgrading KCM - Updates two CI workflow files to use the new centralized upgrade target instead of directly calling the KCM repository's upgrade command
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Makefile | Adds kcm-dev-upgrade target that sets controller memory limits to 128Mi before upgrade |
| .github/workflows/pr_test_mgmt_upgrade.yml | Replaces direct dev-upgrade call with new kcm-dev-upgrade target |
| .github/workflows/pr_test_adopted_upgrade.yml | Replaces direct dev-upgrade call with new kcm-dev-upgrade target |
AndrejsPon00
force-pushed
the
fix-kcm-oom-issue
branch
from
26f13d5 to
a51a29c
Compare
gmlexx
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.