Skip to content

fix: move PKI_PATH to defaultCR env#713

Merged
denis-ryzhkov merged 1 commit into
mainfrom
collector-env-fix
Jan 26, 2026
Merged

fix: move PKI_PATH to defaultCR env#713
denis-ryzhkov merged 1 commit into
mainfrom
collector-env-fix

Conversation

@gmlexx
Copy link
Copy Markdown
Collaborator

@gmlexx gmlexx commented Jan 26, 2026

Due to mergeOverwrite in opentelemetry-kube-stack chart we cannot customize individual collector env independently from defaultCR env without loosing defaultCR env.

Copilot AI review requested due to automatic review settings January 26, 2026 15:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue with environment variable configuration in OpenTelemetry collectors caused by the mergeOverwrite behavior in the opentelemetry-kube-stack chart. The PKI_PATH environment variable is moved from individual collector configurations to the defaultCRConfig.env section to prevent loss of default environment variables when customizing individual collectors.

Changes:

  • Relocated PKI_PATH environment variable from individual collector specs to defaultCRConfig.env across demo files and chart values
  • Implemented custom merge logic in child multi-cluster service template to properly concatenate environment variables instead of overwriting them
  • Updated chart defaults to set PKI_PATH at the defaultCRConfig level with value var/lib/k0s

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
demo/collectors-values.yaml Moved PKI_PATH from collectors.controller-k0s.env to defaultCRConfig.env
demo/cluster/adopted-cluster-regional.yaml Added PKI_PATH environment variable to defaultCRConfig.env for regional cluster
demo/cluster/adopted-cluster-child.yaml Added PKI_PATH environment variable to defaultCRConfig.env for child cluster
charts/kof-collectors/values.yaml Relocated PKI_PATH from controller-k0s.env to defaultCRConfig.env with default value
charts/kof-child/templates/child-multi-cluster-service.yaml Implemented custom environment variable concatenation logic to preserve default env vars when merging collector values

Comment thread demo/collectors-values.yaml
Comment thread demo/cluster/adopted-cluster-regional.yaml
Comment thread demo/cluster/adopted-cluster-child.yaml
Comment thread charts/kof-collectors/values.yaml
Comment thread charts/kof-child/templates/child-multi-cluster-service.yaml
@denis-ryzhkov denis-ryzhkov merged commit d72c299 into main Jan 26, 2026
16 checks passed
@denis-ryzhkov denis-ryzhkov deleted the collector-env-fix branch January 26, 2026 16:43
@github-project-automation github-project-automation Bot moved this to Done in k0rdent Jan 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants