fix: move PKI_PATH to defaultCR env#713
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue with environment variable configuration in OpenTelemetry collectors caused by the mergeOverwrite behavior in the opentelemetry-kube-stack chart. The PKI_PATH environment variable is moved from individual collector configurations to the defaultCRConfig.env section to prevent loss of default environment variables when customizing individual collectors.
Changes:
- Relocated
PKI_PATHenvironment variable from individual collector specs todefaultCRConfig.envacross demo files and chart values - Implemented custom merge logic in child multi-cluster service template to properly concatenate environment variables instead of overwriting them
- Updated chart defaults to set
PKI_PATHat thedefaultCRConfiglevel with valuevar/lib/k0s
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| demo/collectors-values.yaml | Moved PKI_PATH from collectors.controller-k0s.env to defaultCRConfig.env |
| demo/cluster/adopted-cluster-regional.yaml | Added PKI_PATH environment variable to defaultCRConfig.env for regional cluster |
| demo/cluster/adopted-cluster-child.yaml | Added PKI_PATH environment variable to defaultCRConfig.env for child cluster |
| charts/kof-collectors/values.yaml | Relocated PKI_PATH from controller-k0s.env to defaultCRConfig.env with default value |
| charts/kof-child/templates/child-multi-cluster-service.yaml | Implemented custom environment variable concatenation logic to preserve default env vars when merging collector values |
denis-ryzhkov
approved these changes
Jan 26, 2026
AndrejsPon00
approved these changes
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to mergeOverwrite in opentelemetry-kube-stack chart we cannot customize individual collector env independently from defaultCR env without loosing defaultCR env.