Conversation
63dd9ef to
2ec440e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new umbrella Helm chart (charts/kof) that simplifies KOF deployment by using FluxCD to manage the sequential installation of all KOF components. It consolidates the previously separate deployment steps (dev-operators-deploy, dev-storage-deploy, dev-collectors-deploy, dev-ms-deploy) into a single dev-deploy command.
Changes:
- Adds new umbrella chart
charts/kofwith FluxCD-based orchestration - Removes
victoria-metrics-operatordependency fromkof-mothershipchart (now managed at umbrella level) - Updates deployment workflow to use single
make dev-deploycommand - Removes obsolete
demo/collectors-values.yamlfile
Reviewed changes
Copilot reviewed 27 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/kof/Chart.yaml | New umbrella chart metadata |
| charts/kof/values.yaml | Comprehensive configuration for all KOF components with FluxCD orchestration |
| charts/kof/values-local.yaml | Local development values with reduced resource requirements |
| charts/kof/templates/helmrepositories.yaml | FluxCD HelmRepository resources |
| charts/kof/templates/helmreleases.yaml | FluxCD HelmRelease resources for sequential deployment |
| charts/kof/templates/helmcharts.yaml | FluxCD HelmChart resources |
| charts/kof/templates/_helpers.tpl | Helm template helpers |
| charts/kof/templates/NOTES.txt | Installation notes and monitoring instructions |
| charts/kof/README.md.gotmpl | Helm docs template |
| charts/kof/README.md | Auto-generated documentation |
| charts/kof/.helmignore | Standard Helm ignore patterns |
| charts/kof-mothership/Chart.yaml | Removed victoria-metrics-operator dependency |
| charts/kof-mothership/values.yaml | Removed victoria-metrics-operator configuration |
| charts/kof-mothership/templates/k0rdent/kof/helm-repo.yaml | Deleted (now managed by umbrella chart) |
| charts/kof-mothership/README.md | Updated dependencies documentation |
| Makefile | Consolidated deployment targets into dev-deploy |
| kof-operator/README.md | Updated deployment command reference |
| docs/dev.md | Updated deployment documentation |
| demo/collectors-values.yaml | Removed obsolete file |
| .pre-commit-config.yaml | Added helm-docs for kof chart |
| .github/workflows/*.yaml | Updated CI workflows to use new deployment command |
| .github/copilot-instructions.md | Updated quick start instructions |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AndrejsPon00
previously approved these changes
Feb 3, 2026
denis-ryzhkov
requested changes
Feb 4, 2026
Collaborator
denis-ryzhkov
left a comment
There was a problem hiding this comment.
This PR improves KOF UX a lot, thanks!
Please check the suggestions below.
denis-ryzhkov
requested changes
Feb 5, 2026
denis-ryzhkov
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #580
Fixes #715
k0rdent/docs#712