fix: duplication in kubelet metric led to wrong ContainerHightMemoryUsage calculation#735
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #729 by addressing duplicate metrics in the kubelet that caused incorrect ContainerHighMemoryUsage alert calculations. The fix adds additional label filters to ensure only cadvisor metrics are used in the memory usage calculation.
Changes:
- Updated the
ContainerHighMemoryUsagePrometheus alert rule expression to filter out duplicate kubelet metrics - Auto-generated corresponding Helm chart documentation update
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| charts/kof-mothership/values.yaml | Added container!="" and metrics_path="/metrics/cadvisor" filters to the alert rule expression |
| charts/kof-mothership/README.md | Auto-generated documentation reflecting the values.yaml changes |
denis-ryzhkov
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #729