feat: Auto check values consistency#769
Merged
Merged
Conversation
Alex-Vovchuk
requested review from
AndrejsPon00,
denis-ryzhkov and
gmlexx
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an automated consistency check to ensure selected defaults in the main Helm chart values (charts/kof/values.yaml) stay aligned with corresponding component chart values.yaml, and wires the check into developer/CI workflows.
Changes:
- Added a Python script to compare main chart component
.valuesagainst component chartvalues.yaml(with special fallback handling forkof-child/kof-regional). - Added a local pre-commit hook and a GitHub Actions workflow to run the consistency check on PRs.
- Updated developer documentation to point contributors to the pre-commit steps.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
scripts/check_values_consistency.py |
New checker script that parses YAML and compares main chart component values to component chart defaults, with child/regional fallback logic. |
docs/dev.md |
Documentation tweak referencing pre-commit steps. |
.pre-commit-config.yaml |
Adds a local hook that runs the new consistency checker. |
.github/workflows/pr_check_values_consistency.yml |
Adds a PR workflow job to run the consistency checker when charts change. |
gmlexx
requested changes
Feb 11, 2026
Collaborator
gmlexx
left a comment
gmlexx
left a comment
There was a problem hiding this comment.
Please also fix all inconsistency issues found by this script in this PR
Alex-Vovchuk
changed the title
gmlexx
previously approved these changes
Feb 18, 2026
denis-ryzhkov
requested changes
Feb 18, 2026
Collaborator
denis-ryzhkov
left a comment
denis-ryzhkov
left a comment
There was a problem hiding this comment.
Great script in general, thanks.
Few suggestions below.
denis-ryzhkov
requested changes
Feb 18, 2026
denis-ryzhkov
requested changes
Feb 19, 2026
Collaborator
denis-ryzhkov
left a comment
denis-ryzhkov
left a comment
There was a problem hiding this comment.
Suggestions are applied, please rebase to fix CI
# Conflicts: # charts/kof-mothership/README.md
Alex-Vovchuk
force-pushed
the
auto-check-values-consistency
branch
from
f2bfec1 to
34e8f23
Compare
denis-ryzhkov
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kof/values.yamland$component/values.yaml#738