Conversation
gmlexx
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the development workflow for deploying KOF locally. It simplifies the documentation to use make dev-deploy instead of manual helm commands, and improves the Makefile logic for restarting the kof-operator deployment after image updates.
Changes:
- Simplified development documentation to recommend
make dev-deploywith examples for full and single-chart deployments - Fixed operator restart logic to run outside the wait block and conditionally based on whether kof-mothership is being deployed
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/dev.md | Replaced manual helm command with make dev-deploy and added example for single-chart redeployment |
| Makefile | Moved kof-operator restart logic outside the wait block to execute for both full deployments and kof-mothership-specific deployments, regardless of SKIP_WAIT setting |
denis-ryzhkov
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also restart kof-operator if updated kof-mothership chart