fix: duplicate MultiClusterService rendering when Istio is disabled#804
Merged
Conversation
denis-ryzhkov
requested changes
Feb 20, 2026
denis-ryzhkov
requested changes
Feb 20, 2026
denis-ryzhkov
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the Helm templates in kof-child and kof-regional would always iterate over both
trueandfalsefor the Istio loop, even whenistio.enabledwas set tofalse.As a result, the chart rendered duplicate
MultiClusterServiceresources with identical IDs, causing Kustomize reconciliation failures (already registered id):Change
Updated the loop logic to conditionally build the iteration list based on
$.Values.istio.enabled:istio.enabled = true→ iterate overtrueandfalse(existing behavior)istio.enabled = false→ iterate only overfalseThis prevents duplicate manifests from being rendered while preserving the intended behavior when Istio is enabled.
Impact
Suggestion
Include this fix as part of a patch-release to make
kofusable again in non-istio setups. Otherwise, if I am not mistaken, it is currently a hard blocker.