Skip to content

chore: vendor opentelemetry types and events recording to bump kcm to 1.8.0#846

Merged
gmlexx merged 1 commit into
mainfrom
bump-operator-go-deps
Mar 11, 2026
Merged

chore: vendor opentelemetry types and events recording to bump kcm to 1.8.0#846
gmlexx merged 1 commit into
mainfrom
bump-operator-go-deps

Conversation

@gmlexx
Copy link
Copy Markdown
Collaborator

@gmlexx gmlexx commented Mar 9, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 9, 2026 15:39
@gmlexx gmlexx changed the title chore: venrod opentelemetry types and events recordign to bump kcm to 1.8.0 chore: venrod opentelemetry types and events recording to bump kcm to 1.8.0 Mar 9, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the operator’s Go dependencies to support bumping KCM to v1.8.0, removes the direct dependency on the upstream OpenTelemetry Operator module by vendoring the required API types, and adjusts event recording and imports accordingly.

Changes:

  • Bump dependencies including github.com/K0rdent/kcm to v1.8.0 and sigs.k8s.io/controller-runtime to v0.23.1.
  • Vendor OpenTelemetry Operator v1beta1 API types into internal/otelv1beta1 and switch code/tests to use the internal package.
  • Migrate controller event recording from k8s.io/client-go/tools/record to k8s.io/client-go/tools/events (and adjust test fakes / manager wiring).

Reviewed changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
kof-operator/internal/server/tests/suite_test.go Switch server test scheme registration/imports to internal vendored OTel v1beta1 types.
kof-operator/internal/server/tests/collector_metrics_handler_test.go Update test imports to use internal vendored OTel types.
kof-operator/internal/server/handlers/collector_metrics_handler.go Update handler import to internal vendored OTel types.
kof-operator/internal/otelv1beta1/types.go Add vendored OpenTelemetryCollector v1beta1 API type definitions.
kof-operator/internal/otelv1beta1/groupversion_info.go Add vendored group/version registration helpers (with kubebuilder skip markers).
kof-operator/internal/otelv1beta1/deepcopy.go Add vendored deepcopy implementations for the v1beta1 types.
kof-operator/internal/k8s/otel.go Switch OTel API import to internal vendored package.
kof-operator/internal/k8s/client.go Register internal vendored OTel types into the client scheme.
kof-operator/internal/controller/suite_test.go Update controller test setup to use tools/events fake recorder.
kof-operator/internal/controller/record/recorder.go Change recorder abstraction to tools/events EventRecorder and update helper methods.
kof-operator/go.mod Dependency bumps/removals (drop upstream opentelemetry-operator module; bump controller-runtime, flux APIs, etc.).
kof-operator/go.sum Reflect dependency graph changes from the module updates.
kof-operator/cmd/main.go Adjust goroutine/event-recorder wiring to match updated APIs.

Comment thread kof-operator/cmd/main.go
Comment thread kof-operator/internal/controller/record/recorder.go
@gmlexx gmlexx changed the title chore: venrod opentelemetry types and events recording to bump kcm to 1.8.0 chore: vendor opentelemetry types and events recording to bump kcm to 1.8.0 Mar 10, 2026
@gmlexx gmlexx force-pushed the bump-operator-go-deps branch from 6576ab7 to ad013e1 Compare March 11, 2026 11:01
@gmlexx gmlexx merged commit 2f70270 into main Mar 11, 2026
8 checks passed
@gmlexx gmlexx deleted the bump-operator-go-deps branch March 11, 2026 13:26
@github-project-automation github-project-automation Bot moved this to Done in k0rdent Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants