Skip to content

fix: Customizable HelmRepository.spec in umbrella kof chart#860

Merged
denis-ryzhkov merged 1 commit into
k0rdent:mainfrom
denis-ryzhkov:umbrella-vs-custom-registry
Mar 13, 2026
Merged

fix: Customizable HelmRepository.spec in umbrella kof chart#860
denis-ryzhkov merged 1 commit into
k0rdent:mainfrom
denis-ryzhkov:umbrella-vs-custom-registry

Conversation

@denis-ryzhkov
Copy link
Copy Markdown
Collaborator

@denis-ryzhkov denis-ryzhkov commented Mar 13, 2026

  • We need optional HelmRepository.spec values like secretRef and certSecretRef.
  • The hardcoded type: "default" should be customizable too.
  • Deleted the unused kcm.kof.repo.spec too.
  • Tests:

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables more flexible FluxCD HelmRepository configuration in the kof umbrella chart by allowing users to pass through optional HelmRepository.spec fields (e.g., secretRef, certSecretRef) and by making the VictoriaMetrics repo type configurable instead of hardcoded.

Changes:

  • Add global.helmRepo.spec pass-through values in the umbrella chart values/docs.
  • Refactor helmrepositories.yaml to render repo fields via value blocks and remove hardcoded VictoriaMetrics repo type.
  • Simplify kof-mothership chart repo values/docs to reference an existing HelmRepository name only.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
charts/kof/values.yaml Adds global.helmRepo.spec and sets a default victoria-metrics-operator.repo.type.
charts/kof/templates/helmrepositories.yaml Renders HelmRepository type/url from values and appends global.helmRepo.spec.
charts/kof/README.md Documents the new global.helmRepo.spec and the VM repo type value.
charts/kof-mothership/values.yaml Removes embedded repo spec/type/url and keeps only repo name.
charts/kof-mothership/README.md Updates docs to reflect the repo name-only configuration.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread charts/kof/templates/helmrepositories.yaml
Comment thread charts/kof/templates/helmrepositories.yaml
Comment thread charts/kof/values.yaml
Copy link
Copy Markdown
Collaborator

@a13x5 a13x5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remapping approach may be reconsidered.
Rest looks good.

Comment thread charts/kof/templates/helmrepositories.yaml
@denis-ryzhkov denis-ryzhkov merged commit 7724b8e into k0rdent:main Mar 13, 2026
25 checks passed
@github-project-automation github-project-automation Bot moved this to Done in k0rdent Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants