fix: Customizable HelmRepository.spec in umbrella kof chart#860
Merged
denis-ryzhkov merged 1 commit intoMar 13, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Enables more flexible FluxCD HelmRepository configuration in the kof umbrella chart by allowing users to pass through optional HelmRepository.spec fields (e.g., secretRef, certSecretRef) and by making the VictoriaMetrics repo type configurable instead of hardcoded.
Changes:
- Add
global.helmRepo.specpass-through values in the umbrella chart values/docs. - Refactor
helmrepositories.yamlto render repo fields via value blocks and remove hardcoded VictoriaMetrics repo type. - Simplify
kof-mothershipchart repo values/docs to reference an existing HelmRepository name only.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/kof/values.yaml | Adds global.helmRepo.spec and sets a default victoria-metrics-operator.repo.type. |
| charts/kof/templates/helmrepositories.yaml | Renders HelmRepository type/url from values and appends global.helmRepo.spec. |
| charts/kof/README.md | Documents the new global.helmRepo.spec and the VM repo type value. |
| charts/kof-mothership/values.yaml | Removes embedded repo spec/type/url and keeps only repo name. |
| charts/kof-mothership/README.md | Updates docs to reflect the repo name-only configuration. |
You can also share your feedback on Copilot code review. Take the survey.
a13x5
reviewed
Mar 13, 2026
Collaborator
a13x5
left a comment
There was a problem hiding this comment.
Remapping approach may be reconsidered.
Rest looks good.
a13x5
approved these changes
Mar 13, 2026
denis-ryzhkov
added a commit
that referenced
this pull request
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HelmRepository.specvalues likesecretRefandcertSecretRef.type: "default"should be customizable too.kcm.kof.repo.spectoo.