fix: Double custom registry in pod image

[denis-ryzhkov]

• Fixes InvalidImageName when using custom registry.
• Our template collided with VMO template here and here resulting in the double registry component added to the pod image.
• We did not detect it with default global.registry: docker.io because docker pull docker.io/docker.io/victoriametrics/vmstorage:v1.105.0-cluster actually works, unexpectedly.
• We did not detect it with custom registries earlier too, probably due to some fixes in the upstream charts.

[Copilot]

Pull request overview

Fixes image name rendering when a custom registry is configured by removing redundant registry prefixing that led to InvalidImageName (e.g., registry/registry/...) and by making the default global registry value empty so component defaults are preserved unless explicitly overridden.

Changes:

• Remove manual registry-prefixing of VictoriaMetrics component image repositories in VMCluster/VMAuth templates (letting upstream/operator logic handle registry composition).
• Change global.registry default in kof-mothership from docker.io to empty and align docs accordingly.
• Simplify registry selection logic in several deployments/templates to consistently use global.registry when set.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
charts/kof-storage/templates/victoria/vmcluster.yaml	Stops manually prefixing VMCluster component image repositories with global registry to avoid double-registry.
charts/kof-storage/templates/victoria/vmauth.yaml	Stops manually prefixing VMAuth image repository with global registry to avoid double-registry.
charts/kof-regional/templates/regional-multi-cluster-service.yaml	Removes special-casing that treated docker.io as “empty” registry for multi-cluster rendered values.
charts/kof-mothership/values.yaml	Sets global.registry default to "" to avoid implicit registry override and double-registry behavior.
charts/kof-mothership/templates/victoria/vmcluster.yaml	Removes manual image repository rewriting for VMCluster components.
charts/kof-mothership/templates/promxy/promxy-deployment.yaml	Uses global.registry when set, otherwise falls back to chart image registry.
charts/kof-mothership/templates/kof-operator/operator-deployment.yaml	Uses global.registry when set, otherwise falls back to chart image registry.
charts/kof-mothership/templates/acl/deployment.yaml	Uses global.registry when set, otherwise falls back to chart image registry.
charts/kof-mothership/README.md	Updates documented default for global.registry to "" and adjusts description.
charts/kof-collectors/templates/opentelemetry/instrumentation.yaml	Uses global.registry when set, otherwise falls back to upstream default registry.
charts/kof-child/templates/child-multi-cluster-service.yaml	Removes special-casing that treated docker.io as “empty” registry for multi-cluster rendered values.

---

You can also share your feedback on Copilot code review. Take the survey.