fix: pass daemon collector image tag from chart version#888
Merged
Conversation
gmlexx
requested review from
Alex-Vovchuk,
AndrejsPon00 and
denis-ryzhkov
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to ensure the OpenTelemetry daemon collector image tag used in multi-cluster deployments (regional/child) tracks the Helm chart version, reducing drift between chart releases and deployed collector images.
Changes:
- Set
opentelemetry-kube-stack.collectors.daemon.image.tagto the chart version in the regional MultiClusterService template. - Set
opentelemetry-kube-stack.collectors.daemon.image.tagto the chart version in the child MultiClusterService template (non-Istio branch).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| charts/kof-regional/templates/regional-multi-cluster-service.yaml | Injects daemon collector image tag into the kof-collectors values payload using the chart version. |
| charts/kof-child/templates/child-multi-cluster-service.yaml | Injects daemon collector image tag into the child collectors values payload (currently only for non-Istio). |
AndrejsPon00
approved these changes
Mar 26, 2026
denis-ryzhkov
approved these changes
Mar 26, 2026
gmlexx
added a commit
that referenced
this pull request
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing installation from latest main builds