fix: Merge of envoy-gateway related fixes from release/v1.8.1#947
Merged
Conversation
* ci: wait for httproutes creation * fix: update envoy-gateway to 1.7.1 * fix: correct helm charts order waiting * fix: npm audit fix * chore: KOF 1.8.1-rc4
…bal` values without `--set-file globalValues=`. Split upstream `values:` to avoid validation issues. (k0rdent#922)
denis-ryzhkov
requested review from
Alex-Vovchuk,
AndrejsPon00 and
gmlexx
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR pulls in envoy-gateway-related fixes from release/v1.8.1, primarily adjusting how Helm values are composed for multi-cluster services and aligning chart values structures.
Changes:
- Refactors
kof-regionalandkof-childMultiClusterService templates to stop usingglobalValuesand to merge global values via.Values.global. - Adjusts
kof-regionalvalues structure foringress-nginxandenvoy-gatewayto add a dedicatedvalues: {}sub-map and movesgatewaydefaults. - Regenerates Helm dependency lockfiles and makes small chart YAML cleanups.
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/kof-storage/Chart.lock | Regenerated dependency lock metadata (timestamp update). |
| charts/kof-mothership/Chart.lock | Regenerated dependency lock metadata (timestamp update). |
| charts/kof-propagation/Chart.yaml | Minor formatting/normalization (no functional dependency change). |
| charts/kof-operators/values.yaml | Removes grafana-operator image override values. |
| charts/kof-regional/values.yaml | Adds values: {} blocks for ingress-nginx/envoy-gateway and repositions gateway defaults. |
| charts/kof-regional/templates/regional-multi-cluster-service.yaml | Updates values merge strategy and envoy-gateway/ingress-nginx values composition. |
| charts/kof-child/values.yaml | Removes globalValues stanza from defaults. |
| charts/kof-child/templates/child-multi-cluster-service.yaml | Updates values merge strategy to use .Values.global-based structure. |
gmlexx
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.