fix: update vmuser MCS propagation when spec changes#963
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the VMUser controller’s MultiClusterService (MCS) propagation logic so that when the desired propagation spec changes, the existing MCS is updated instead of being left stale.
Changes:
- Switch VMUser creation flow to
createOrUpdatePropagationMCSwhenMCSConfigis set. - Add logic to fetch an existing propagation
MultiClusterServiceand update itsSpecwhen it differs. - Add event recording for propagation MCS update success/failure.
AndrejsPon00
requested review from
Alex-Vovchuk,
denis-ryzhkov and
gmlexx
as code owners
AndrejsPon00
force-pushed
the
fix-vmuser-mcs-upgrade
branch
from
1e70d01 to
2d7a765
Compare
denis-ryzhkov
previously approved these changes
Apr 24, 2026
gmlexx
requested changes
Apr 26, 2026
Collaborator
gmlexx
left a comment
gmlexx
left a comment
There was a problem hiding this comment.
Please cover the fix with unit test
AndrejsPon00
force-pushed
the
fix-vmuser-mcs-upgrade
branch
from
2d7a765 to
4343c72
Compare
gmlexx
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.