feat: state sum to show sum of available points#1076
Open
jasonlewis wants to merge 2 commits intokalkih:devfrom
Open
feat: state sum to show sum of available points#1076jasonlewis wants to merge 2 commits intokalkih:devfrom
jasonlewis wants to merge 2 commits intokalkih:devfrom
Conversation
|
This is actually relevant to the issue is just opened: #1095 I think your solution should be more holistics and cover all the |
|
My understanding is that the solution should work for all aggregation functions. It fetches values from previously generated points. "sum" is just another type of state; it does not correspond with any agg func. Prove me wrong or please merge this one. I'd be happy to use it ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted a way to show the default state of the graph as a sum of the available points rather than the current/last point.
This adds a new
sumvalue forstatewhich sums the available points. This does rely on the fix within #1075 for it to work as it expectspointsto always be defined.