feat: add pause, unpause, show, hide events & hook it into broadphase#1041
Open
dragoncoder047 wants to merge 14 commits intokaplayjs:masterfrom
Open
feat: add pause, unpause, show, hide events & hook it into broadphase#1041dragoncoder047 wants to merge 14 commits intokaplayjs:masterfrom
dragoncoder047 wants to merge 14 commits intokaplayjs:masterfrom
Conversation
Member
|
Isn't the resize observer observing canvas? So if you have own canvas with dimensions set on page, it wouldn't trigger onTabResize even if window is resized until the canvas itself gets resized as well - which would be then misleading. Shouldn't it be kept as onResize then? By default canvas is set to window viewport dimensions and is mostly used like that, but it's not the only way, if true. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe what issue(s) this PR fixes.
closes #844 mostly.
Summary