feat: added scrollDelta() function to app state#1079
Open
SobennaStory wants to merge 2 commits intokaplayjs:masterfrom
Open
feat: added scrollDelta() function to app state#1079SobennaStory wants to merge 2 commits intokaplayjs:masterfrom
SobennaStory wants to merge 2 commits intokaplayjs:masterfrom
Conversation
dragoncoder047
suggested changes
Apr 21, 2026
Contributor
There was a problem hiding this comment.
- You don't need to create a new Vec2 every time we get a scroll, you can just
.set()it to the new values.
2. You need to set My dumb ass can't read. Never mind.scrollDelta to zero on frames where we don't have a wheel event. I don't want another #326.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #981
Added scroll delta as a pollable input, consistent with how mouse delta position works. Instead of only being able to react to scroll via the onScroll callback, you can now also read it directly like any other input state.