fix(server): Exit clean on unhandledRejections.#3092
Merged
johnjbarton merged 1 commit intokarma-runner:masterfrom Aug 4, 2018
Merged
fix(server): Exit clean on unhandledRejections.#3092johnjbarton merged 1 commit intokarma-runner:masterfrom
johnjbarton merged 1 commit intokarma-runner:masterfrom
Conversation
Add a handler for unhandledRejections, log error and disconnect all, then exit. Also remove broken, untested rejection handler in middleware. Prior to karma-runner#3064, this block was probably unreachable; the arguments to serveStaticFile are incorrect.
lusarz
approved these changes
Aug 4, 2018
Contributor
lusarz
left a comment
lusarz
left a comment
There was a problem hiding this comment.
Looks good to me.
Cccording to travis commit message seems to be inappropriate :)
Contributor
Author
|
I think the travis problem was fixed several of my recent commits. We should see less of these now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a handler for unhandledRejections, log error and disconnect all, then exit.
Also remove broken, untested rejection handler in middleware. Prior to #3064,
this block was probably unreachable; the arguments to serveStaticFile are incorrect.