Fix parsing of content type fields from METS

[ThomasEdvardsen]

What changed

• setIPContentType now reads mets/@TYPE and uses mets/@csip:OTHERTYPE only when TYPE=OTHER
• contentInformationType is now populated during parsing for both main and representation METS
  • uses mets/@csip:CONTENTINFORMATIONTYPE
  • uses mets/@csip:OTHERCONTENTINFORMATIONTYPE only when CONTENTINFORMATIONTYPE=OTHER
• Added unit tests to cover the four reported cases plus edge cases:
  • TYPE="Text" ignores OTHERTYPE
  • TYPE="Other" uses OTHERTYPE
  • CONTENTINFORMATIONTYPE="GeoData" ignores OTHERCONTENTINFORMATIONTYPE
  • CONTENTINFORMATIONTYPE="OTHER" uses OTHERCONTENTINFORMATIONTYPE
  • error when OTHER is set but corresponding other field is empty
  • blank CONTENTINFORMATIONTYPE leaves default

Why

Parsing currently:

• reads contentType from content-information attributes (wrong source)
• never sets contentInformationType at all
  This causes parsed SIPs to return incorrect defaults even when METS is correct (E-ARK SIP parse ignores CONTENTINFORMATIONTYPE and misreads TYPE/OTHERTYPE for contentType #372).

Related

Closes #372

[dosubot]

Related Documentation

Checked 5 published document(s) in 1 knowledge base(s). No updates required.

^{How did I do? Any feedback?}  

[ThomasEdvardsen]

Im sorry for the massive changes, but its required by the Checkstyle job 😳