Conversation
This commit adds a new workflow `.github/workflows/build.yml` to: 1. Build the Android application (app and lib) using Gradle. 2. Build the WASM module using Emscripten, including the compilation of the OpenJPEG dependency. This ensures both the Android and WASM components are verifiable in CI.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
Switched from `emscripten-core/emsdk@v3` (which does not exist as an action) to `mymindstorm/setup-emsdk@v14`. This should resolve the workflow setup error.
- Updated `.github/workflows/build.yml` triggers to `main` and `feature/**`. - Added `-DBUILD_SHARED_LIBS=OFF -DBUILD_STATIC_LIBS=ON` to the OpenJPEG CMake configuration to force a static build, resolving the `ADD_LIBRARY` shared library error with Emscripten.
Adopted appropriate CMake options for the WASM build: - `-DBUILD_CODEC=OFF`: Skips building executables, as we only need the library for linking. - `-DBUILD_THIRDPARTY` is omitted as it is dependent on `BUILD_CODEC=ON`. - Maintained `-DBUILD_SHARED_LIBS=OFF` to support Emscripten.
|
できたWASMファイルをartifactに保存してほしい。有効期限は１日間 |
Added a step to upload the |
Added a step to the workflow to upload the generated `openjpeg_core.wasm` file as a build artifact with a retention period of 1 day, as requested.
1 participant
Added
.github/workflows/build.ymlto automate build verification.The workflow includes:
androidjob: Sets up JDK 17 and runs./gradlew assembleDebugin thesample/directory.wasmjob: Sets up Emscripten, builds OpenJPEG (submodule), and runs theemcccommand specified in README.md.PR created automatically by Jules for task 7977971218154819814 started by @keiji