Type-hint rename_schema.py#847
Conversation
obi1kenobi
left a comment
There was a problem hiding this comment.
One minor typing nit, otherwise looks great!
This reverts commit 7579db6.
Codecov Report
@@ Coverage Diff @@
## master #847 +/- ##
=========================================
Coverage ? 94.76%
=========================================
Files ? 108
Lines ? 8398
Branches ? 0
=========================================
Hits ? 7958
Misses ? 440
Partials ? 0
Continue to review full report at Codecov.
|
| @@ -186,36 +230,35 @@ class RenameSchemaTypesVisitor(Visitor): | |||
| } | |||
There was a problem hiding this comment.
Do we specifically need this to be a class attribute here? If not, can we move it to module-level and make it sit right adjacent to the Union definition that it duplicates?
There was a problem hiding this comment.
It's specifically used for RenameSchemaTypesVisitor, as it explicitly leaves out renaming the schema query type (i.e. SchemaQuery). RenameQueryTypeFieldsVisitor is the visitor that modifies the schema query type. Moving this class attribute to module-level could be confusing considering that we do actually modify the schema query type, just not in this particular class.
Co-authored-by: Predrag Gruevski <predrag@kensho.com>
Co-authored-by: Predrag Gruevski <predrag@kensho.com>
Step 1 as outlined in PR 834