Skip to content

fix: add missing control-plane label into lifecycle operator service#1148

Merged
thschue merged 11 commits into
keptn:mainfrom
nlamirault:fix/control-plane-label
Apr 3, 2023
Merged

fix: add missing control-plane label into lifecycle operator service#1148
thschue merged 11 commits into
keptn:mainfrom
nlamirault:fix/control-plane-label

Conversation

@nlamirault

Copy link
Copy Markdown
Contributor

Fix #1146

@netlify

netlify Bot commented Mar 29, 2023

Copy link
Copy Markdown

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit 05d7a9e
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/642a8428ef81f20008a6ecc3
😎 Deploy Preview https://deploy-preview-1148--keptn-lifecycle-toolkit.netlify.app/docs/crd-ref/lifecycle/v1alpha3
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nlamirault nlamirault changed the title Add: control-plane label into Lifecycle Operator feat: control-plane label into Lifecycle Operator Mar 29, 2023
@nlamirault nlamirault force-pushed the fix/control-plane-label branch from abfce5c to 7d0312e Compare March 29, 2023 12:37
nlamirault and others added 10 commits April 3, 2023 10:25
Fix keptn#1146

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
…eptn#1158)

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
…tn#1152)

Signed-off-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Thomas Schuetz <38893055+thschue@users.noreply.github.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
…1160)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Signed-off-by: Florian Bacher <florian.bacher@dynatrace.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
…st to 6b58da3 (keptn#1141)

Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@github-actions github-actions Bot added cert-manager documentation Improvements or additions to documentation helm metrics-operator ops labels Apr 3, 2023
@github-actions github-actions Bot removed cert-manager documentation Improvements or additions to documentation ops helm metrics-operator labels Apr 3, 2023
@sonarqubecloud

sonarqubecloud Bot commented Apr 3, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov

codecov Bot commented Apr 3, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1148 (d08957c) into main (3859059) will increase coverage by 2.40%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
+ Coverage   56.68%   59.08%   +2.40%     
==========================================
  Files          92      128      +36     
  Lines        8500    10041    +1541     
==========================================
+ Hits         4818     5933    +1115     
- Misses       3548     3892     +344     
- Partials      134      216      +82     

see 46 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (?)
component-tests 60.61% <ø> (-1.23%) ⬇️
lifecycle-operator 78.48% <ø> (?)
metrics-operator 77.57% <ø> (?)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies changed the title feat: control-plane label into Lifecycle Operator fix: add missing control-plane label into lifecycle operator service Apr 3, 2023

@thschue thschue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

klt-lifecycle-operator-metric service missing label: control-plane

5 participants