Skip to content

fix: fix examples restart make command, reduce prometheus resources#1158

Merged
mowies merged 2 commits into
keptn:mainfrom
mowies:fix-examples
Mar 30, 2023
Merged

fix: fix examples restart make command, reduce prometheus resources#1158
mowies merged 2 commits into
keptn:mainfrom
mowies:fix-examples

Conversation

@mowies

@mowies mowies commented Mar 30, 2023

Copy link
Copy Markdown
Member

This PR

  • reduces the replicas for promtheus services in the examples so that they can be run easier on less powerful environments
  • fixes the make restart command so that it works with the prefixes that helm applies to deployments

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@netlify

netlify Bot commented Mar 30, 2023

Copy link
Copy Markdown

Deploy Preview for keptn-lifecycle-toolkit ready!

Name Link
🔨 Latest commit be000c6
🔍 Latest deploy log https://app.netlify.com/sites/keptn-lifecycle-toolkit/deploys/64255b2a2b13ad00088ef8c2
😎 Deploy Preview https://deploy-preview-1158--keptn-lifecycle-toolkit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov

codecov Bot commented Mar 30, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1158 (80efb82) into main (b27adf1) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1158      +/-   ##
==========================================
+ Coverage   59.03%   59.08%   +0.04%     
==========================================
  Files         126      126              
  Lines       10033    10033              
==========================================
+ Hits         5923     5928       +5     
+ Misses       3892     3889       -3     
+ Partials      218      216       -2     

see 3 files with indirect coverage changes

Flag Coverage Δ
certificate-operator 64.15% <ø> (ø)
component-tests 59.97% <ø> (-0.22%) ⬇️
lifecycle-operator 78.52% <ø> (ø)
metrics-operator 77.57% <ø> (ø)
scheduler 21.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@mowies mowies changed the title fix(examples): fix restart make command, reduce prometheus resources fix: fix examples restart make command, reduce prometheus resources Mar 30, 2023
@odubajDT

Copy link
Copy Markdown
Contributor

Can you please fix the semantic PR check ? @mowies

Signed-off-by: Moritz Wiesinger <moritz.wiesinger@dynatrace.com>
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thschue thschue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mowies mowies merged commit 06b10a8 into keptn:main Mar 30, 2023
@mowies mowies deleted the fix-examples branch March 30, 2023 10:45
@keptn-bot keptn-bot mentioned this pull request Mar 30, 2023
nlamirault pushed a commit to nlamirault/lifecycle-toolkit that referenced this pull request Apr 3, 2023
…eptn#1158)

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants