Skip to content

Comments

Remove the class-level VAT setting#837

Merged
klaasnicolaas merged 1 commit intoklaasnicolaas:mainfrom
illright:remove-class-vat
Aug 21, 2025
Merged

Remove the class-level VAT setting#837
klaasnicolaas merged 1 commit intoklaasnicolaas:mainfrom
illright:remove-class-vat

Conversation

@illright
Copy link
Contributor

Proposed change

Remove the option to specify VAT preference on a class level

Additional information

Checklist

  • I have updated the documentation if needed.
  • I have updated the tests if needed.

@codecov
Copy link

codecov bot commented Aug 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.64%. Comparing base (414ef4e) to head (f9c03c8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files           5        5              
  Lines         281      280       -1     
  Branches       26       26              
==========================================
- Hits          280      279       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@klaasnicolaas klaasnicolaas added the breaking-change A breaking change for existing users. label Aug 20, 2025
@klaasnicolaas klaasnicolaas merged commit 42cb5d4 into klaasnicolaas:main Aug 21, 2025
14 of 15 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

breaking-change A breaking change for existing users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move VAT class parameter to specific functions

2 participants