Skip to content

Comments

fix: VAT option value assignment in gas and electricity requests#920

Merged
klaasnicolaas merged 1 commit intomainfrom
klaas-2025-016
Dec 8, 2025
Merged

fix: VAT option value assignment in gas and electricity requests#920
klaasnicolaas merged 1 commit intomainfrom
klaas-2025-016

Conversation

@klaasnicolaas
Copy link
Owner

Proposed change

Fixed a bug where fallback wouldn't work when you don't pass a VAT parameter to legacy helpers

Additional information

  • This PR fixes or closes issue: fixes #

Checklist

  • I have updated the documentation if needed.
  • I have updated the tests if needed.

@klaasnicolaas klaasnicolaas added the bugfix Fixing a bug. label Dec 8, 2025
@klaasnicolaas klaasnicolaas merged commit 8db5eb4 into main Dec 8, 2025
31 checks passed
@klaasnicolaas klaasnicolaas deleted the klaas-2025-016 branch December 8, 2025 00:20
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4c72198) to head (ece90d5).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #920   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          302       302           
  Branches        26        26           
=========================================
  Hits           302       302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bugfix Fixing a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant