Skip to content

Improve jobrunner wait code to retry on recoverable errors #45

@dsimansk

Description

@dsimansk

Per PR discussion: https://github.com/knative-sandbox/kn-plugin-event/pull/42/files#r674008140

Let investigate the RetryWatcher from client-go tools and knative/client waiting loop to introduce retry on error in the waiting loop.

There are cases that may result in premature closing of ResultChan, that's caused by recoverable failure. Detecting such occasions and re-creating watcher instance might be very desired.

https://github.com/knative-sandbox/kn-plugin-event/blob/0e1fe36db37682a10548808563a38c7e5ac3814c/pkg/k8s/jobrunner.go#L68-L96

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions