Skip to content

add tag-to-host support#944

Open
kahirokunn wants to merge 1 commit intoknative-extensions:mainfrom
kahirokunn:kahiro/tag-to-host-self-contained
Open

add tag-to-host support#944
kahirokunn wants to merge 1 commit intoknative-extensions:mainfrom
kahirokunn:kahiro/tag-to-host-self-contained

Conversation

@kahirokunn
Copy link
Member

@kahirokunn kahirokunn commented Mar 18, 2026

Summary

  • Implement networking.internal.knative.dev/tag-to-host annotation support for Gateway API HTTPRoutes
  • When a KIngress carries the tag-to-host annotation, the reconciler synthesizes additional host-based HTTPRoutes from header-based tag paths
  • This enables ingress implementations that cannot do header-based routing to route by hostname instead

Test plan

  • Unit tests for DesiredHTTPRouteRules with tag-to-host annotation
  • Unit tests for deduplication (existing host-based rules not duplicated)
  • Integration test for reconciler with tag-to-host annotation
  • All existing tests pass

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 18, 2026
@knative-prow
Copy link

knative-prow bot commented Mar 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kahirokunn
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from dprotaso and skonto March 18, 2026 02:54
@kahirokunn kahirokunn force-pushed the kahiro/tag-to-host-self-contained branch from 90caf1a to bcc57e8 Compare March 18, 2026 02:57
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 77.77778% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.33%. Comparing base (13e2037) to head (2edaa5a).

Files with missing lines Patch % Lines
pkg/reconciler/ingress/resources/tags.go 71.42% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #944      +/-   ##
==========================================
- Coverage   76.38%   76.33%   -0.05%     
==========================================
  Files          17       18       +1     
  Lines        1266     1289      +23     
==========================================
+ Hits          967      984      +17     
- Misses        263      268       +5     
- Partials       36       37       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kahirokunn kahirokunn marked this pull request as draft March 18, 2026 03:25
@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2026
@kahirokunn kahirokunn force-pushed the kahiro/tag-to-host-self-contained branch from bcc57e8 to bdb0d6a Compare March 18, 2026 04:02
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 18, 2026
Signed-off-by: kahirokunn <okinakahiro@gmail.com>
@kahirokunn kahirokunn force-pushed the kahiro/tag-to-host-self-contained branch from bdb0d6a to 2edaa5a Compare March 18, 2026 04:35
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 18, 2026
@kahirokunn kahirokunn marked this pull request as ready for review March 18, 2026 04:36
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant